Codecov Report

❌ Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.19%. Comparing base (dcb0028) to head (e9f6002).
⚠️ Report is 7 commits behind head on main.

@@            Coverage Diff             @@
##             main    #5787      +/-   ##
==========================================
- Coverage   97.20%   97.19%   -0.01%     
==========================================
  Files          30       30              
  Lines        3393     3391       -2     
  Branches     1436     1421      -15     
==========================================
- Hits         3298     3296       -2     
  Misses         95       95              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@balajis-qb can you review?

@claude Review this PR

Claude finished @martijnrusschen's task —— View job

PR Review: React 19 Compatibility Fix

Todo List

• Read and analyze changed files
• Review dependency updates
• Check TypeScript fixes
• Review configuration changes
• Provide comprehensive feedback

✅ Overall Assessment

This is a solid fix for React 19 compatibility issues. The changes are focused, well-reasoned, and address the core problems described in the PR.

🔍 Detailed Review

Dependency Updates ✅

package.json: Updated @floating-ui/react from ^0.27.3 to ^0.27.15

• Good: Significant version jump with important React 19 compatibility fixes
• Note: The PR description mentions updating from 0.27.12, but git diff shows from 0.27.3 - likely the version was already partially updated

TypeScript Fixes ✅

src/with_floating.tsx:51: Fixed ref typing

- const arrowRef: React.RefObject<HTMLElement | null> = useRef(null);
+ const arrowRef = useRef<SVGSVGElement>(null);

• Excellent: More specific typing for SVG arrow elements
• Good: Addresses the TypeScript compilation errors mentioned in the PR

Additional improvements in with_floating.tsx:

• Added proper displayName for better debugging (line 74)
• Changed from arrow function to function declaration for better stack traces

Component Modernization ✅

src/popper_component.tsx: Class → Functional Component conversion

• Good: Converted from class component to functional component
• Performance: Eliminates class overhead
• Maintainability: More modern React patterns
• Compatibility: Better alignment with React 19's direction

Development Environment Fix ✅

docs-site/vite.config.js: Added React aliases

alias: {
  // Ensure single React instance to avoid "Invalid hook call" errors
  react: path.resolve(__dirname, "node_modules/react"),
  "react-dom": path.resolve(__dirname, "node_modules/react-dom"),
}

• Excellent: Prevents multiple React instances during development
• Good: Clear comment explaining the purpose

🤔 Coverage Note

Codecov shows 1 missing line in src/popper_component.tsx. This is likely due to:

• The class → functional component conversion changing code paths
• The missing coverage appears to be on a conditional branch that may be harder to test

📝 Minor Suggestions

1. Testing: Consider adding specific tests for React 19 compatibility if not already covered
2. Documentation: The changes are well-documented in the PR description

✨ What I Like

• Targeted fixes: Each change addresses a specific React 19 issue
• Type safety: Improved TypeScript definitions
• Code quality: Modernization from class to functional components
• Clear intent: Good comments and commit messages

🎯 Conclusion

Status: Ready to merge ✅

This PR successfully resolves React 19 compatibility issues with focused, high-quality changes. The dependency update, TypeScript fixes, and development environment improvements all work together to solve the "Invalid hook call" errors while modernizing the codebase.